Re: [PATCH v2] net: preserve IP control block during GSO segmentation

From: David Miller
Date: Wed Jan 13 2016 - 15:51:19 EST


From: Konstantin Khlebnikov <koct9i@xxxxxxxxx>
Date: Fri, 08 Jan 2016 15:21:46 +0300

> Skb_gso_segment() uses skb control block during segmentation.
> This patch adds 32-bytes room for previous control block which
> will be copied into all resulting segments.
>
> This patch fixes kernel crash during fragmenting forwarded packets.
> Fragmentation requires valid IP CB in skb for clearing ip options.
> Also patch removes custom save/restore in ovs code, now it's redundant.
>
> Signed-off-by: Konstantin Khlebnikov <koct9i@xxxxxxxxx>
> Link: http://lkml.kernel.org/r/CALYGNiP-0MZ-FExV2HutTvE9U-QQtkKSoE--KN=JQE5STYsjAA@xxxxxxxxxxxxxx

If this works I definitely prefer this approach to the other patch
where the CB is copied back and forth.

Any other reviewers?