Re: [PATCH 0/2] mm: memcontrol: cgroup2 memory statistics
From: Andrew Morton
Date: Wed Jan 13 2016 - 17:49:21 EST
On Wed, 13 Jan 2016 17:01:07 -0500 Johannes Weiner <hannes@xxxxxxxxxxx> wrote:
> Hi Andrew,
>
> these patches add basic memory statistics so that new users of cgroup2
> have some inkling of what's going on, and are not just confronted with
> a single number of bytes used.
>
> This is very short-notice, but also straight-forward. It would be cool
> to get this in along with the lifting of the cgroup2 devel flag.
>
> Michal, Vladimir, what do you think? We'll also have to figure out how
> we're going to represent and break down the "kmem" consumers.
>
It would be nice to see example output, and a description of why this
output was chosen: what was included, what was omitted, why it was
presented this way, what units were chosen for displaying the stats and
why. Will the things which are being displayed still be relevant (or
even available) 10 years from now. etcetera.
And the interface should be documented at some point. Doing it now
will help with the review of the proposed interface.
Because this stuff is forever and we have to get it right.