Re: [PATCH] uapi: update install list after nvme.h rename

[Jiri Slaby]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 01/14/2016, 02:17 AM, Mike Frysinger wrote:
> On 12 Jan 2016 09:45, Jiri Slaby wrote:
>> On 01/11/2016, 02:14 AM, Mike Frysinger wrote:
>>> Commit 9d99a8dda154 ("nvme: move hardware structures out of the
>>> uapi version of nvme.h") renamed nvme.h to nvme_ioctl.h, but
>>> the uapi list still refers to nvme.h.  People trying to install
>>> the headers hit a failure as the header no longer exists.
>> 
>> Wouldn't reverting the rename be nicer to userspace? So that the 
>> filename is preserved and anybody who #included nvme.h still can
>> do so?
> 
> i have no opinion on either route
> 
> on a related note, shouldn't headers install be part of the
> automatic kernel checks that are run against repos on kernel.org ?
> who runs that thing ?

I have been thinking about at least 'test -f' for all 'headers-y'
during make all. What do you think, Michal?

thanks,
- -- 
js
suse labs
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJWl1ukAAoJEL0lsQQGtHBJq6oP/jNH+N/Hf8JtZN0xOmv2qhnS
x7n/jlDvE8ineXVFlAQghu5+RDq4tSJ6lllKjGLh5Y3IyHF24zbsAwl2ojnORxH9
ALrcs4KorQXNU3WrzY5+5Ah6oUtHp2mKBpDOPYHiCA0yhZxHDWZm4ecF3lhRb6sn
jFkVpgvmD0sd5XUjsbIa/B0ugD8dMjGOdc7kZVpdEN1zmGYKoMD6gs/LTVvh3gUJ
ohWsSTEBYlUeq/TnFcU+WbnH3Fxbgapktbqo9HX1O4iKiXQDBYcOBcGnm5mJAcPz
RhEMDAL7/x/R/pzcnwMPAjPseLUdLs8jTSeOF+BNyzsHTallneN3C9UXa+LSj4Wf
F0yd485xyz+gHDd2G9CG6jEQ8SurWk8Bb4BxLNKALBmmEIy6FbgIsxUjeY0JMMDj
C8iRCI+vyaijTmBiNRxTWHsbN7AtH4X3f3/DjmWEVCro6QjRj9g5SPykCckN+c8F
NvVVnbjXBQLTh69RIyDTQ1E6hKA+E3605OVCrY1YMpcx8/714IxuWhA9BCxVzF7p
RnKa6AAVzylf7WMlX5qrQ1GoHmCzi8GPY6tlFpoQ/FFgN2Y/uS3zIRlqkSXBd0lb
yMFjkfBPpNu4Xe3L6AYD7sAUl3U1VKnvKqqyTuTZx8qbFb2xdTDKYYiRZEw4yc+b
9ODjcHuxDLcJSjnlTU8N
=tIm3
-----END PGP SIGNATURE-----