Re: [PATCH v1 1/2] lib/string_helpers: export string_units_{2,10} for others

[Andy Shevchenko]

On Tue, 2016-01-12 at 15:13 +0200, Andy Shevchenko wrote:
> There is one user coming which would like to use those string arrays.
> It might
> be useful for any other user in the future.

Please, comment on the idea, but discard both patches, I'm cooking
better approach.

> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---
> Âinclude/linux/string_helpers.h |ÂÂ3 +++
> Âlib/string_helpers.cÂÂÂÂÂÂÂÂÂÂÂ| 21 ++++++++++++---------
> Â2 files changed, 15 insertions(+), 9 deletions(-)
> 
> diff --git a/include/linux/string_helpers.h
> b/include/linux/string_helpers.h
> index dabe643..1d16240 100644
> --- a/include/linux/string_helpers.h
> +++ b/include/linux/string_helpers.h
> @@ -10,6 +10,9 @@ enum string_size_units {
> Â	STRING_UNITS_2,		/* use binary powers of 2^10
> */
> Â};
> Â
> +extern const char *const string_units_10[];
> +extern const char *const string_units_2[];
> +
> Âvoid string_get_size(u64 size, u64 blk_size, enum string_size_units
> units,
> Â		ÂÂÂÂÂchar *buf, int len);
> Â
> diff --git a/lib/string_helpers.c b/lib/string_helpers.c
> index 5939f63..3a4c812 100644
> --- a/lib/string_helpers.c
> +++ b/lib/string_helpers.c
> @@ -13,6 +13,15 @@
> Â#include <linux/string.h>
> Â#include <linux/string_helpers.h>
> Â
> +const char * const string_units_10[] = {
> +	"B", "kB", "MB", "GB", "TB", "PB", "EB", "ZB", "YB",
> +};
> +EXPORT_SYMBOL(string_units_10);
> +const char * const string_units_2[] = {
> +	"B", "KiB", "MiB", "GiB", "TiB", "PiB", "EiB", "ZiB", "YiB",
> +};
> +EXPORT_SYMBOL(string_units_2);
> +
> Â/**
> Â * string_get_size - get the size in the specified units
> Â * @size:	The size to be converted in blocks
> @@ -29,15 +38,9 @@
> Âvoid string_get_size(u64 size, u64 blk_size, const enum
> string_size_units units,
> Â		ÂÂÂÂÂchar *buf, int len)
> Â{
> -	static const char *const units_10[] = {
> -		"B", "kB", "MB", "GB", "TB", "PB", "EB", "ZB", "YB"
> -	};
> -	static const char *const units_2[] = {
> -		"B", "KiB", "MiB", "GiB", "TiB", "PiB", "EiB",
> "ZiB", "YiB"
> -	};
> Â	static const char *const *const units_str[] = {
> -		[STRING_UNITS_10] = units_10,
> -		[STRING_UNITS_2] = units_2,
> +		[STRING_UNITS_10] = string_units_10,
> +		[STRING_UNITS_2] = string_units_2,
> Â	};
> Â	static const unsigned int divisor[] = {
> Â		[STRING_UNITS_10] = 1000,
> @@ -92,7 +95,7 @@ void string_get_size(u64 size, u64 blk_size, const
> enum string_size_units units,
> Â	}
> Â
> Â out:
> -	if (i >= ARRAY_SIZE(units_2))
> +	if (i >= ARRAY_SIZE(string_units_2))
> Â		unit = "UNK";
> Â	else
> Â		unit = units_str[units][i];

-- 
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy