Re: [PATCH 3/9] perf build: Test correct path of perf in build-test

From: Wangnan (F)
Date: Thu Jan 14 2016 - 05:14:58 EST




On 2016/1/14 18:04, Jiri Olsa wrote:
On Wed, Jan 13, 2016 at 12:17:16PM +0000, Wang Nan wrote:

SNIP

( eval $$cmd ) >> $@ 2>&1 && \
rm -f $@
+KBUILD_OUTPUT_DIR := ../..
+ifneq ($(O),)
+ KBUILD_OUTPUT_DIR := $(O)
+endif
+
make_kernelsrc:
@echo "- make -C <kernelsrc> $(PARALLEL_OPT) tools/perf"
$(call clean); \
(make -C ../.. $(PARALLEL_OPT) tools/perf) > $@ 2>&1 && \
- test -x perf && rm -f $@ || (cat $@ ; false)
+ test -x $(KBUILD_OUTPUT_DIR)/tools/perf && rm -f $@ || (cat $@ ; false)
do you miss one extra /perf in here? like it should be

test -x $(KBUILD_OUTPUT_DIR)/tools/perf/perf

Right. Will fix.

Thank you.