Re: [PATCH v4 1/2] memory-hotplug: add automatic onlining policy for the newly added memory

From: David Rientjes
Date: Thu Jan 14 2016 - 16:46:32 EST


On Thu, 14 Jan 2016, Vitaly Kuznetsov wrote:

> > My suggestion is to just simply document that auto-onlining can add the
> > memory but fail to online it and the failure is silent to userspace. If
> > userspace cares, it can check the online status of the added memory blocks
> > itself.
>
> The problem is not only that it's silent, but also that
> /sys/devices/system/memory/*/state will lie as we create all memory
> blocks in MEM_ONLINE state and from online_pages() error we can't figure
> out which particular block failed. 'v5' which I sent yesterday is
> supposed to fix the issue (blocks are onlined with
> memory_block_change_state() which handles failures.
>

Would you mind documenting that in the memory-hotplug.txt as an add-on
patch to your v5, which appears ready to go?