Re: [PATCH 3/5] x86/mcheck/AMD: Reduce number of blocks scanned per bank

From: Borislav Petkov
Date: Thu Jan 14 2016 - 17:54:24 EST


On Thu, Jan 14, 2016 at 04:48:22PM -0600, Aravind Gopalakrishnan wrote:
> True. But that BlkPtr logic also will undergo changes as it's interpretation
> for future processors is different.

But there still must be a bit there which says "this register is valid",
like MCi_MISC[63].

And so I'd very much prefer checking a bit (or bits) instead of relying
on defines.

> We are guaranteed to have all the MISC registers (all 5 of them) going
> forward.

Guarantees are worth nothing.

--
Regards/Gruss,
Boris.

ECO tip #101: Trim your mails when you reply.