Re: [PATCH RFC 1/1] ASoC: fsl_ssi: Make fifo watermark and maxburst settings device tree options

From: Timur Tabi
Date: Fri Jan 15 2016 - 08:46:38 EST


Mark Brown wrote:
>I admit it's a grey area, but the hardware doesn't work if you use the wrong
>value, and it is a fixed value per device. A p1022ds would use a different
>value than in in i.MX6, and once you pick a value, it's the same no matter
>which sample rate, buffer size, etc you choose.

Caleb's original message suggested this was rate dependant.

Yeah, I just noticed that. In that case, I agree that a device tree property is inappropriate, unless it's an array that contains tuples of sample rates and watermark/maxburst settings. That would get unwieldy very easily, though.