Re: [PATCH V2 1/7] usb-misc: sisusbvga: Fix coding style: horizontal whitespace changes
From: Peter Senna
Date: Fri Jan 15 2016 - 13:09:10 EST
CC: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
On Friday, January 15, 2016 18:56 CET, Joe Perches <joe@xxxxxxxxxxx> wrote:
> On Fri, 2016-01-15 at 18:41 +0100, Peter Senna Tschudin wrote:
> > This patch fixes whitespace coding style issues that can be fixed
> > within a single line.
>
> trivia:
>
> > diff --git a/drivers/usb/misc/sisusbvga/sisusb.c b/drivers/usb/misc/sisusbvga/sisusb.c
> []
> > @@ -549,7 +549,7 @@ static int sisusb_recv_bulk_msg(struct sisusb_usb_data *sisusb, int ep, int len,
> > Â}
> > Â
> > Âstatic int sisusb_send_packet(struct sisusb_usb_data *sisusb, int len,
> > - struct sisusb_packet *packet)
> > + struct sisusb_packet *packet)
>
> I think all of these should use indentation alignment
> to open parenthesis.
That was my original idea too, but I have the impression things are different for usb, at least for usb-host. Alan, can you comment on this continuation line style issue here?