Re: [PATCH v2 03/10] Input: synaptics-rmi4: Add device tree support for RMI4 I2C devices

[Andrew Duggan]

Hi Audrey,

On 01/15/2016 03:24 AM, Andrey Gusakov wrote:
> On Fri, Jan 15, 2016 at 2:44 AM, Andrew Duggan <aduggan@xxxxxxxxxxxxx> wrote:
> > Add devicetree binding for I2C devices and add bindings for optional
> > parameters in the function drivers. Parameters for function drivers are
> > defined in child nodes for each of the functions.
> >
> > Signed-off-by: Andrew Duggan <aduggan@xxxxxxxxxxxxx>
> ...
> > +#ifdef CONFIG_OF
> > +static void rmi_function_of_probe(struct rmi_function *fn)
> > +{
> > +       char of_name[8];
> > +
> > +       snprintf(of_name, sizeof(of_name), "rmi4-f%02x",
> > +               fn->fd.function_number);
> > +       fn->dev.of_node = of_find_node_by_name(
> > +                               fn->rmi_dev->xport->dev->of_node, of_name);
> > +}
> Name like "rmi4-f11" including 0 terminator does not fit in 8 chars.
> This leads to the inability to find the correct OF node and get settings.

Oh, I missed that! I'll fix it in the next patch series.

Thanks,
Andrew

> Sorry for previous HTML noise.