Re: [PATCH v3] pipe: limit the per-user amount of pages allocated in pipes

From: Willy Tarreau
Date: Mon Jan 18 2016 - 07:33:56 EST


On Mon, Jan 18, 2016 at 08:22:10PM +0800, kbuild test robot wrote:
> Hi Willy,
>
> [auto build test WARNING on linus/master]
> [also build test WARNING on next-20160118]
> [cannot apply to tip/sched/core v4.4]
> [if your patch is applied to the wrong git tree, please drop us a note to help improving the system]

Well, I don't understand how to read the output here, I'm sorry. Since this
patch modifies the user_struct, it has a dependency on the following patch
just merged into Linus tree :

712f4aa ("unix: properly account for FDs passed over unix sockets")

That's probably why you have the "cannot apply" error above.

Willy

> url: https://github.com/0day-ci/linux/commits/Willy-Tarreau/pipe-limit-the-per-user-amount-of-pages-allocated-in-pipes/20160118-190854
> reproduce: make htmldocs
>
> All warnings (new ones prefixed by >>):
>
> include/linux/jbd2.h:439: warning: No description found for parameter 'i_transaction'
> include/linux/jbd2.h:439: warning: No description found for parameter 'i_next_transaction'
> include/linux/jbd2.h:439: warning: No description found for parameter 'i_list'
> include/linux/jbd2.h:439: warning: No description found for parameter 'i_vfs_inode'
> include/linux/jbd2.h:439: warning: No description found for parameter 'i_flags'
> include/linux/jbd2.h:495: warning: No description found for parameter 'h_rsv_handle'
> include/linux/jbd2.h:495: warning: No description found for parameter 'h_reserved'
> include/linux/jbd2.h:495: warning: No description found for parameter 'h_type'
> include/linux/jbd2.h:495: warning: No description found for parameter 'h_line_no'
> include/linux/jbd2.h:495: warning: No description found for parameter 'h_start_jiffies'
> include/linux/jbd2.h:495: warning: No description found for parameter 'h_requested_credits'
> include/linux/jbd2.h:495: warning: No description found for parameter 'h_lockdep_map'
> include/linux/jbd2.h:1038: warning: No description found for parameter 'j_chkpt_bhs[JBD2_NR_BATCH]'
> include/linux/jbd2.h:1038: warning: No description found for parameter 'j_devname[BDEVNAME_SIZE+24]'
> include/linux/jbd2.h:1038: warning: No description found for parameter 'j_average_commit_time'
> include/linux/jbd2.h:1038: warning: No description found for parameter 'j_min_batch_time'
> include/linux/jbd2.h:1038: warning: No description found for parameter 'j_max_batch_time'
> include/linux/jbd2.h:1038: warning: No description found for parameter 'j_commit_callback'
> include/linux/jbd2.h:1038: warning: No description found for parameter 'j_failed_commit'
> include/linux/jbd2.h:1038: warning: No description found for parameter 'j_chksum_driver'
> include/linux/jbd2.h:1038: warning: No description found for parameter 'j_csum_seed'
> include/linux/jbd2.h:1038: warning: Excess struct/union/enum/typedef member 'j_history' description in 'journal_s'
> include/linux/jbd2.h:1038: warning: Excess struct/union/enum/typedef member 'j_history_max' description in 'journal_s'
> include/linux/jbd2.h:1038: warning: Excess struct/union/enum/typedef member 'j_history_cur' description in 'journal_s'
> fs/jbd2/transaction.c:429: warning: No description found for parameter 'rsv_blocks'
> fs/jbd2/transaction.c:429: warning: No description found for parameter 'gfp_mask'
> fs/jbd2/transaction.c:429: warning: No description found for parameter 'type'
> fs/jbd2/transaction.c:429: warning: No description found for parameter 'line_no'
> fs/jbd2/transaction.c:505: warning: No description found for parameter 'type'
> fs/jbd2/transaction.c:505: warning: No description found for parameter 'line_no'
> fs/jbd2/transaction.c:635: warning: No description found for parameter 'gfp_mask'
> >> include/linux/pipe_fs_i.h:61: warning: No description found for parameter 'user'
>
> vim +/user +61 include/linux/pipe_fs_i.h
>
> 0845718da Jens Axboe 2007-06-12 45 **/
> 17374ff1a Jens Axboe 2007-06-04 46 struct pipe_inode_info {
> 72b0d9aac Al Viro 2013-03-21 47 struct mutex mutex;
> 17374ff1a Jens Axboe 2007-06-04 48 wait_queue_head_t wait;
> 35f3d14db Jens Axboe 2010-05-20 49 unsigned int nrbufs, curbuf, buffers;
> 17374ff1a Jens Axboe 2007-06-04 50 unsigned int readers;
> 17374ff1a Jens Axboe 2007-06-04 51 unsigned int writers;
> ba5bb1473 Al Viro 2013-03-21 52 unsigned int files;
> 17374ff1a Jens Axboe 2007-06-04 53 unsigned int waiting_writers;
> 17374ff1a Jens Axboe 2007-06-04 54 unsigned int r_counter;
> 17374ff1a Jens Axboe 2007-06-04 55 unsigned int w_counter;
> 35f3d14db Jens Axboe 2010-05-20 56 struct page *tmp_page;
> 17374ff1a Jens Axboe 2007-06-04 57 struct fasync_struct *fasync_readers;
> 17374ff1a Jens Axboe 2007-06-04 58 struct fasync_struct *fasync_writers;
> 35f3d14db Jens Axboe 2010-05-20 59 struct pipe_buffer *bufs;
> 89cb9d10e Willy Tarreau 2016-01-18 60 struct user_struct *user;
> 17374ff1a Jens Axboe 2007-06-04 @61 };
> 17374ff1a Jens Axboe 2007-06-04 62
> f84d75199 Jens Axboe 2006-05-01 63 /*
> f84d75199 Jens Axboe 2006-05-01 64 * Note on the nesting of these functions:
> f84d75199 Jens Axboe 2006-05-01 65 *
> cac36bb06 Jens Axboe 2007-06-14 66 * ->confirm()
> f84d75199 Jens Axboe 2006-05-01 67 * ->steal()
> f84d75199 Jens Axboe 2006-05-01 68 * ...
> f84d75199 Jens Axboe 2006-05-01 69 * ->map()
>
> :::::: The code at line 61 was first introduced by commit
> :::::: 17374ff1aa9ce2a0597416a16729474b538af443 pipe: move pipe_inode_info structure decleration up before it's used
>
> :::::: TO: Jens Axboe <jens.axboe@xxxxxxxxxx>
> :::::: CC: Jens Axboe <jens.axboe@xxxxxxxxxx>
>
> ---
> 0-DAY kernel test infrastructure Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all Intel Corporation