Re: [Intel-gfx] [PATCH] drm/i915: fix itnull.cocci warnings (fwd)

[Daniel Vetter]

On Mon, Jan 18, 2016 at 04:49:06PM +0100, Julia Lawall wrote:
> List_for_each entry binds its first argument to an offset from the list
> pointer, so this should not be NULL.
> 
> Generated by: scripts/coccinelle/iterators/itnull.cocci
> 
> Signed-off-by: Fengguang Wu <fengguang.wu@xxxxxxxxx>
> ---
> 
> Please take the patch only if it's a positive warning. Thanks!

Against which tree is this? I can't find this anywhere like that ...
-Daniel

> 
>  intel_display.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -16498,7 +16498,7 @@ void intel_modeset_preclose(struct drm_d
>  		struct intel_flip_work *work;
> 
>  		list_for_each_entry(work, &crtc->flip_work, head) {
> -			if (work && work->event &&
> +			if (work->event &&
>  			    work->event->base.file_priv == file) {
>  				kfree(work->event);
>  				work->event = NULL;
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch