Re: [PATCH] x86: static_cpu_has_safe: discard dynamic check after init

[Borislav Petkov]

On Mon, Jan 18, 2016 at 11:45:18AM -0800, H. Peter Anvin wrote:
> I think the two-byte optimization is the real issue if there is one at
> all.

Well, we do optimize the jumps for a couple releases now, see
recompute_jump(). So we would always get the short JMP, if made possible
by how gcc lays out the code so that the target is not far away. If the
JMP to the dynamic branch doesn't get nopped out anyway, that is.

We have "debug-alternative" to dump exactly what happens during
patching.

> I don't care about the inittext, and unless I'm misremembering
> completely altinstructions also get ejected.

Ah yes, they do.

> So I don't personally object to killing off the unsafe variant.

Ok.

-- 
Regards/Gruss,
    Boris.

SUSE Linux GmbH, GF: Felix ImendÃrffer, Jane Smithard, Graham Norton, HRB 21284 (AG NÃrnberg)
--