Re: [PATCH RESEND] omap_hdq: fix usecount handling

From: Evgeniy Polyakov
Date: Tue Jan 19 2016 - 11:44:09 EST


Hi Andreas

>From w1 perspective this doesn't break things :)
Greg, please pull it into your tree if no one objects.

Acked-by: Evgeniy Polyakov <zbr@xxxxxxxxxxx>

16.01.2016, 15:48, "Andreas Kemnade" <andreas@xxxxxxxxxxxx>:
> hdq_usecount was set to zero after a successful read, so
> omap_hdq_put could not properly free resources which leads
> e.g. to increasing usecounts in lsmod output
>
> Signed-off-by: Andreas Kemnade <andreas@xxxxxxxxxxxx>
> ---
>  drivers/w1/masters/omap_hdq.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/w1/masters/omap_hdq.c b/drivers/w1/masters/omap_hdq.c
> index 0e2f43b..a2eec97 100644
> --- a/drivers/w1/masters/omap_hdq.c
> +++ b/drivers/w1/masters/omap_hdq.c
> @@ -618,7 +618,6 @@ static u8 omap_w1_read_byte(void *_hdq)
>
>          hdq_disable_interrupt(hdq_data, OMAP_HDQ_CTRL_STATUS,
>                                ~OMAP_HDQ_CTRL_STATUS_INTERRUPTMASK);
> - hdq_data->hdq_usecount = 0;
>
>          /* Write followed by a read, release the module */
>          if (hdq_data->init_trans) {
> --
> 2.1.4