Re: [PATCH 1/8] rfkill: Documentation and style fixes

From: Johannes Berg
Date: Tue Jan 19 2016 - 15:11:38 EST



> Â/**
> Â * rfkill_resume_polling(struct rfkill *rfkill)
> Â *
> - * Pause polling -- say transmitter is off for other reasons.
> + * Resume polling previously paused with rfkill_pause_polling.
> Â * NOTE: not necessary for suspend/resume -- in that case the
> - * core stops polling anyway
> + * core restarts polling anyway, even if was explicitly paused
> + * before suspending.
> Â */

If this is true, that's a bug, no? Drivers would call pause/resume when
their status changes, and shouldn't be required to check status at
resume time?

johannes