Re: [RFC v1 3/8] x86/boot: add BIT() to boot/bitops.h

From: Luis R. Rodriguez
Date: Wed Jan 20 2016 - 15:34:12 EST


On Wed, Jan 20, 2016 at 12:17 PM, Konrad Rzeszutek Wilk
<konrad.wilk@xxxxxxxxxx> wrote:
> Where? Could you paste in the name of the patch in the description?

+x86_init_early(BIT(X86_SUBARCH_INTEL_MID), NULL, NULL,
+ x86_intel_mid_early_setup);

Is an example, so users of the subarch. Likewise the macro helpers to
make these smaller, see x86_init_early_all() on the patch "x86/init:
add linker table support".

And then of course the checkers:

+static bool x86_init_fn_supports_subarch(struct x86_init_fn *fn)
+{
+ if (!fn->supp_hardware_subarch) {
+ pr_err("Init sequence fails to declares any supported
subarchs: %pF\n", fn->early_init);
+ WARN_ON(1);
+ }
+ if (BIT(boot_params.hdr.hardware_subarch) & fn->supp_hardware_subarch)
+ return true;
+ return false;
+}

Luis