Re: regression 4.4: deadlock in with cgroup percpu_rwsem

From: Peter Zijlstra
Date: Thu Jan 21 2016 - 04:27:19 EST


On Thu, Jan 21, 2016 at 09:23:09AM +0100, Christian Borntraeger wrote:

> With Tejuns "cpuset: make mm migration asynchronous" and this hack
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c

> index cfdc0e6..0847bab 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -8099,8 +8099,8 @@ void free_fair_sched_group(struct task_group *tg)
> if (tg->cfs_rq)
> kfree(tg->cfs_rq[i]);
> if (tg->se) {
> - if (tg->se[i])
> - remove_entity_load_avg(tg->se[i]);
> +// if (tg->se[i])
> +// remove_entity_load_avg(tg->se[i]);
> kfree(tg->se[i]);
> }
> }
>
> things look good now on the scheduler/cgroup front. Thank you for your
> quick responses and answers.

OK, I'll work with TJ on fixing that. Depending on the complexity of
his patch I might just delete those two lines for -stable.

Thanks!