Re: [PATCH 2/2] vhost: disentangle vring endianness stuff from the core code

From: Cornelia Huck
Date: Thu Jan 21 2016 - 04:56:43 EST


On Wed, 13 Jan 2016 18:09:47 +0100
Greg Kurz <gkurz@xxxxxxxxxxxxxxxxxx> wrote:

> The way vring endianness is being handled currently obfuscates
> the code in vhost_init_used().
>
> This patch tries to fix that by doing the following:
> - move the the code that adjusts endianness to a dedicated helper
> - export this helper so that backends explicitely call it
>
> No behaviour change.
>
> Signed-off-by: Greg Kurz <gkurz@xxxxxxxxxxxxxxxxxx>
> ---
> drivers/vhost/net.c | 3 +++
> drivers/vhost/scsi.c | 3 +++
> drivers/vhost/test.c | 2 ++
> drivers/vhost/vhost.c | 16 +++++++++++-----
> drivers/vhost/vhost.h | 1 +
> 5 files changed, 20 insertions(+), 5 deletions(-)

Reviewed-by: Cornelia Huck <cornelia.huck@xxxxxxxxxx>