Re: [PATCH v6 5/5] hisilicon/dts: Add hi655x pmic dts node

[chenfeng]

Mark,
On 2016/1/20 21:08, Mark Brown wrote:
> On Tue, Jan 19, 2016 at 02:32:04PM +0800, Chen Feng wrote:
> 
>> index 82d2488..6de9881 100644
>> --- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
>> +++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> 
>> +		regulators {
>> +			ldo2: ldo2@a21 {
>> +				regulator-compatible = "LDO2";
> 

I will change it like this:
                regulators {
                        ldo2: LDO2@a21 {
                                regulator-name = "ldo2";
                                regulator-min-microvolt = <2500000>;
                                regulator-max-microvolt = <3200000>;
                                regulator-valid-modes-mask = <0x02>;
                                regulator-enable-ramp-delay = <120>;
                        };

> Why are you using the legacy regulator-compatible property?  No new
> bindings should use this.
> 
>> +				regulator-min-microvolt = <2500000>;
>> +				regulator-max-microvolt = <3200000>;
> 
> This is broken as it misunderstands the purpose of specifying
> constraints.  The constraints are there to say what the safe and
> supported configuration is on a given board, it is not possible to
> provide this information safely in a general include that is used by all
> systems using the PMIC.  Specifying the maximum voltage range for the
> regulators is almost guaranteed to result in at least some
> configurations being enabled which will not work, in the worst case this
> may include configurations which could physically damage the system.
> 
> In general it is very unusual to include the regulators in a .dtsi since
> essentially all the configuration for them should be board specific.
> 
Do you mean that I should move this into dts and enable it by default?