Re: [RFC PATCH 2/2] lightnvm: add non-continuous lun target creation support

From: Wenwei Tao
Date: Thu Jan 21 2016 - 08:58:42 EST


2016-01-21 17:49 GMT+08:00 Matias BjÃrling <mb@xxxxxxxxxxx>:
> On 01/21/2016 10:47 AM, Wenwei Tao wrote:
> <snip>
>>
>> Currently a bitmap of luns already added into nvm_dev, every time we
>> map the luns we check the bitmap.
>> I don't quite understand why we need to add another bitmap?
>
> We can definitely use lun_map that you introduced in the patch.
>
Then I think the suggestion:

>How about extending the functionality to take a bitmap of luns, which
>defines the luns that we like to map. Do the necessary check if any of
>them is in use, and then proceed if all is available?

has already been implemented in this patch.
Hope not misunderstand your suggestion.