Re: [PATCH v15 5/6] fpga: fpga-area and fpga-bus: device tree control for FPGA

From: Moritz Fischer
Date: Thu Jan 21 2016 - 09:44:40 EST


Hi Alan,

minor nits inline:

On Wed, Jan 20, 2016 at 8:24 PM, <atull@xxxxxxxxxxxxxxxxxxxxx> wrote:

> v15: Add altr,fpga-bus implementation
> Change compatible string "fpga-area" -> "altr,fpga-area"

Doesn't look that way down there. Or am I reading the code wrong?

> +static const struct of_device_id fpga_area_of_match[] = {
> + { .compatible = "fpga-area", },

I'm fine with keeping it as fpga-area, this isn't altera specific imho

Cheers,

Moritz