Re: [PATCH] libnvdimm, nfit: Use ACPI_SIG_NFIT instead of hard coded string

From: Ross Zwisler
Date: Thu Jan 21 2016 - 11:09:37 EST


On Thu, Jan 21, 2016 at 08:32:10PM +0800, Lee, Chun-Yi wrote:
> It's minor but that's still better to use ACPI_SIG_NFIT instead of hard
> coded string.
>
> Cc: Ross Zwisler <ross.zwisler@xxxxxxxxxxxxxxx>
> Cc: "Rafael J. Wysocki" <rjw@xxxxxxxxxxxxx>
> Cc: Len Brown <lenb@xxxxxxxxxx>
> Signed-off-by: Lee, Chun-Yi <jlee@xxxxxxxx>

Acked-by: Ross Zwisler <ross.zwisler@xxxxxxxxxxxxxxx>

> drivers/acpi/nfit.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/nfit.c b/drivers/acpi/nfit.c
> index aa45d48..9fb1a6a 100644
> --- a/drivers/acpi/nfit.c
> +++ b/drivers/acpi/nfit.c
> @@ -1739,7 +1739,7 @@ static int acpi_nfit_add(struct acpi_device *adev)
> acpi_size sz;
> int rc;
>
> - status = acpi_get_table_with_size("NFIT", 0, &tbl, &sz);
> + status = acpi_get_table_with_size(ACPI_SIG_NFIT, 0, &tbl, &sz);
> if (ACPI_FAILURE(status)) {
> /* This is ok, we could have an nvdimm hotplugged later */
> dev_dbg(dev, "failed to find NFIT at startup\n");
> --
> 2.1.4
>