Re: [Resend PATCH V5 1/1] NTB: Add support for AMD PCI-Express Non-Transparent Bridge
From: Jon Mason
Date: Thu Jan 21 2016 - 11:37:26 EST
On Thu, Jan 21, 2016 at 2:24 AM, Yu, Xiangliang <Xiangliang.Yu@xxxxxxx> wrote:
>> From: Xiangliang Yu <Xiangliang.Yu@xxxxxxx>
>>
>> > Signed-off-by: Xiangliang Yu <Xiangliang.Yu@xxxxxxx>
>>
>> Yes.
>>
>> > Reviewed-by: Jon Mason <jdmason@xxxxxxxx>
>>
>> Maybe, but that's for Jon to decide. If he accepts it, he will add signed-off-by,
>> but again, that's for Jon to decide.
>
> Jon also spend a lot of time to review the code, I think should show his working
> On this patch.
I appreciate you trying to give me credit for the review of this code,
but this is not how it works. Please read
Documentation/SubmittingPatches
"Reviewed-by:, instead, indicates that the patch has been reviewed and
found acceptable according to the Reviewer's Statement:"
While I am content with this patch, you cannot say that for me :)
Thanks,
Jon
>
>> > Reviewed-by: Allen Hubbe <Allen.Hubbe@xxxxxxx>
>>
>> Adding my reviewed-by is hardly a reason to resend the whole patch.
>
> It will make work easier if merging.
>