Re: [PATCH] staging: iio: replace clk_get() with devm_clk_get()
From: Dan Carpenter
Date: Thu Jan 21 2016 - 14:47:34 EST
On Thu, Jan 21, 2016 at 11:21:53AM -0800, Matt Ranostay wrote:
> > @@ -356,8 +356,6 @@ static int spear_adc_probe(struct platform_device *pdev)
> >
> > errout3:
> > clk_disable_unprepare(st->clk);
>
> Shouldn't errout3 now be errout2.. having a gap would seem odd.
>
> > -errout2:
> > - clk_put(st->clk);
> > errout1:
> > iounmap(st->adc_base_spear6xx);
GW-BASIC style numbered gotos are nonsense. Label names should be name
after what the label does.
err_unprepare:
err_put:
err_iounmap:
But that's something for a different patch, not related to this patch.
regards,
dan carpenter