Re: [PATCH v4 07/21] usb: dwc2: hcd: fix split transfer schedule sequence
From: Doug Anderson
Date: Thu Jan 21 2016 - 19:24:19 EST
Hi,
On Wed, Jan 20, 2016 at 9:24 PM, kbuild test robot <lkp@xxxxxxxxx> wrote:
> Hi Douglas,
>
> [auto build test ERROR on next-20160120]
> [cannot apply to v4.4-rc8 v4.4-rc7 v4.4-rc6 v4.4]
> [if your patch is applied to the wrong git tree, please drop us a note to help improving the system]
>
> url: https://github.com/0day-ci/linux/commits/Douglas-Anderson/usb-dwc2-host-Fix-and-speed-up-all-the-stuff-especially-with-splits/20160121-131414
> config: x86_64-randconfig-x019-01201142 (attached as .config)
> reproduce:
> # save the attached .config to linux build tree
> make ARCH=x86_64
>
> All errors (new ones prefixed by >>):
>
> drivers/usb/dwc2/core.c: In function 'dwc2_hc_start_transfer':
>>> drivers/usb/dwc2/core.c:1876:17: error: 'struct dwc2_hsotg' has no member named 'split_order'
> &hsotg->split_order);
> ^
> --
>>> /bin/bash: line 0: [: -ge: unary operator expected
>
> vim +1876 drivers/usb/dwc2/core.c
>
> 1870 ec_mc = 3;
> 1871 else
> 1872 ec_mc = 1;
> 1873
> 1874 /* Put ourselves on the list to keep order straight */
> 1875 list_move_tail(&chan->split_order_list_entry,
>> 1876 &hsotg->split_order);
> 1877 } else {
> 1878 if (dbg_hc(chan))
> 1879 dev_vdbg(hsotg->dev, "no split\n");
>
> ---
> 0-DAY kernel test infrastructure Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all Intel Corporation
I've got a fix this and the other error reported by the bot. I'll
plan to fix both tomorrow and send up a v5 unless someone gives me
some other feedback on the series that takes me longer than a day to
deal with.
-Doug