Re: [PATCH v2 04/10] rtc: max77686: Use a driver data struct instead hard-coded values

From: Laxman Dewangan
Date: Fri Jan 22 2016 - 05:01:49 EST



On Friday 22 January 2016 01:53 AM, Javier Martinez Canillas wrote:
The driver has some hard-coded values such as the minimum delay needed
before a RTC update or the mask used for the sec/min/hour/etc registers.

Use a data structure that contains these values and pass as driver data
using the platform device ID table for each device.

This allows to make the driver's ops callbacks more generic so other RTC
that are similar but don't have the same values can also be supported.

Signed-off-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx>


Acked-by: Laxman Dewangan <ldewangan@xxxxxxxxxx>