Re: [PATCH v3 3/5] firmware: fold successful fw read early

From: Mimi Zohar
Date: Fri Jan 22 2016 - 06:58:08 EST


On Fri, 2016-01-22 at 02:45 +0100, Luis R. Rodriguez wrote:
> On Mon, Jan 04, 2016 at 03:48:29PM -0500, Josh Boyer wrote:
> > On Wed, Dec 23, 2015 at 4:34 PM, Luis R. Rodriguez
> > <mcgrof@xxxxxxxxxxxxxxxx> wrote:
> > > From: David Howells <dhowells@xxxxxxxxxx>
> > >
> > > We'll be folding in some more checks on fw_read_file_contents(),
> > > this will make the success case easier to follow.
> > >
> > > Signed-off-by: David Howells <dhowells@xxxxxxxxxx>
> > > Signed-off-by: Luis R. Rodriguez <mcgrof@xxxxxxxx>
> >
> > Reviewed-by: Josh Boyer <jwboyer@xxxxxxxxxxxxxxxxx>
>
> Thanks Josh.
>
> Mimi, this is the other patch that I was referring to.

After this patch set, replacing the fw_read_file calls with the
kernel_read_file_from_path() version is straight forward. Nice!

Mimi