Re: [PATCH 07/13] aio: enabled thread based async fsync
From: Andres Freund
Date: Fri Jan 22 2016 - 10:40:11 EST
On 2016-01-12 12:11:28 +1100, Dave Chinner wrote:
> On Mon, Jan 11, 2016 at 05:07:23PM -0500, Benjamin LaHaise wrote:
> > Enable a fully asynchronous fsync and fdatasync operations in aio using
> > the aio thread queuing mechanism.
> >
> > Signed-off-by: Benjamin LaHaise <ben.lahaise@xxxxxxxxxxxxxxxxx>
> > Signed-off-by: Benjamin LaHaise <bcrl@xxxxxxxxx>
>
> Insufficient. Needs the range to be passed through and call
> vfs_fsync_range(), as I implemented here:
>
> https://lkml.org/lkml/2015/10/28/878
FWIW, I finally started to play around with this (or more precisely
https://lkml.org/lkml/2015/10/29/517). There were some prerequisite
changes in postgres required, to actually be able to benefit, delaying
things. First results are good, increasing OLTP throughput
considerably.
It'd also be rather helpful to be able to do
sync_file_range(SYNC_FILE_RANGE_WRITE) asynchronously, i.e. flush
without an implied barrier. Currently this blocks very frequently, even
if there's actually IO bandwidth available.
Regards,
Andres