Re: [PATCH] usb: dwc2: host: Properly set the HFIR

From: Heiko Stuebner
Date: Sat Jan 23 2016 - 12:54:13 EST


Am Freitag, 22. Januar 2016, 15:56:10 schrieb Douglas Anderson:
> According to the most up to date version of the dwc2 databook, the FRINT
> field of the HFIR register should be programmed to:
> * 125 us * (PHY clock freq for HS) - 1
> * 1000 us * (PHY clock freq for FS/LS) - 1
>
> This is opposed to older versions of the doc that claimed it should be:
> * 125 us * (PHY clock freq for HS)
> * 1000 us * (PHY clock freq for FS/LS)
>
> In case you didn't spot it, the difference is the "- 1".
>
> Let's add the "- 1" to match the newest user manual. It's presumed that
> the "- 1" should have always been there and that this was always a
> documentation error. If some hardware needs the "- 1" and other
> hardware doesn't, we'll have to add a configuration parameter for it in
> the future.

Same setup and description as in Doug's 21-patch series, so on a
veyron-jerry:

Tested-by: Heiko Stuebner <heiko@xxxxxxxxx>


Heiko