Re: [PATCH] mmc: dw_mmc: remove repetitive clear interrupt

[Shawn Lin]

On 2016/1/25 12:14, Jaehoon Chung wrote:
> Hi, Shawn.
>
> On 01/25/2016 10:13 AM, Shawn Lin wrote:
> > This patch remove repetitive clear interrupt while
> > probing dw_mmc.
>
> Could you explain to me more?

yes, it's a trivial improvement.

dw_mci_probe clear interrupt and disable all interrupt firstly.
Then commit 2da1d7f2 add a new clear-interrupt operation before
enable some interrupt. I can't see any reason to clear it twice
here. No any side effect I had found in my test pattern without this
. May I miss some important case?
> Best Regards,
> Jaehoon Chung
>
> > Signed-off-by: Shawn Lin <shawn.lin@xxxxxxxxxxxxxx>
> > ---
> >
> >   drivers/mmc/host/dw_mmc.c | 1 -
> >   1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
> > index 7128351..1991872 100644
> > --- a/drivers/mmc/host/dw_mmc.c
> > +++ b/drivers/mmc/host/dw_mmc.c
> > @@ -3117,7 +3117,6 @@ int dw_mci_probe(struct dw_mci *host)
> >   	 * Enable interrupts for command done, data over, data empty,
> >   	 * receive ready and error such as transmit, receive timeout, crc error
> >   	 */
> > -	mci_writel(host, RINTSTS, 0xFFFFFFFF);
> >   	mci_writel(host, INTMASK, SDMMC_INT_CMD_DONE | SDMMC_INT_DATA_OVER |
> >   		   SDMMC_INT_TXDR | SDMMC_INT_RXDR |
> >   		   DW_MCI_ERROR_FLAGS);


--
Best Regards
Shawn Lin