Re: [PATCHSET 0/7] perf tools: Check error during collapsing hist entries
From: Jiri Olsa
Date: Mon Jan 25 2016 - 02:12:28 EST
On Sun, Jan 24, 2016 at 01:37:55PM +0900, Namhyung Kim wrote:
> On Sat, Jan 23, 2016 at 06:01:21PM +0100, Jiri Olsa wrote:
> > On Fri, Jan 22, 2016 at 10:41:33PM +0900, Namhyung Kim wrote:
> > > Hi,
> > >
> > > This patchset checks error case during the process of collapsing hist
> > > entries. It's a preparation of upcoming hierarchy patchset which adds
> > > more work in the collapsing path. If there's an error during this
> > > stage, it'll stop processing and show warning to user.
> > >
> > > Thanks,
> > > Namhyung
> > >
> > >
> > > Namhyung Kim (7):
> > > perf callchain: Check return value of add_child()
> > > perf callchain: Check return value of fill_node()
> > > perf callchain: Add enum match_result for match_chain()
> > > perf callchain: Check return value of split_add_child()
> > > perf callchain: Check return value of append_chain_children()
> > > perf hists: Return error from hists__collapse_resort()
> > > perf report: Check error during report__collapse_hists()
> >
> > I saw 2 other functions allocating memory and not checked:
> > callchain_cursor_append
>
> Ok, but this function is basically for the 'addition' path. Well it's
> also used by the 'collapsing' path but it never allocates new node
> since it reuses the existing ones. I'll prepare a different patchset
> for the 'addition' path later..
>
>
> > callchain_node__make_parent_list
>
> It seems not called in the collapsing path. It should be handled by
> a separate patchset.
ok, with the v2 for patch 3
Acked-by: Jiri Olsa <jolsa@xxxxxxxxxx>
thanks,
jirka