Re: [PATCH v3] perf/x86/amd/power: Add AMD accumulated power reporting mechanism

From: Peter Zijlstra
Date: Mon Jan 25 2016 - 06:13:21 EST


On Mon, Jan 25, 2016 at 04:32:03PM +0800, Huang Rui wrote:
> +struct power_pmu {
> + raw_spinlock_t lock;
> + struct list_head active_list;

Maybe a dumb question, but what is that list for?

You only ever add/del events to/from it, you never iterate it. So why
keep it?

If you drop the list, the lock can go too I think, making all this stuff
simpler.