Re: [PATCH 1/3] gpio: gpio-ich: add support for Intel Baytrail

From: Lee Jones
Date: Mon Jan 25 2016 - 07:44:10 EST


On Sat, 23 Jan 2016, Antoine Tenart wrote:

> This patch adds support for the Braytrail series, with the hardware
> blink capability.
>
> Signed-off-by: Antoine Tenart <antoine.tenart@xxxxxxxxxxxxxxxxxx>
> ---
> drivers/gpio/gpio-ich.c | 12 ++++++++++++
> include/linux/mfd/lpc_ich.h | 1 +

Acked-by: Lee Jones <lee.jones@xxxxxxxxxx>

> 2 files changed, 13 insertions(+)
>
> diff --git a/drivers/gpio/gpio-ich.c b/drivers/gpio/gpio-ich.c
> index 4ba7ed502131..6f5fcae32855 100644
> --- a/drivers/gpio/gpio-ich.c
> +++ b/drivers/gpio/gpio-ich.c
> @@ -384,6 +384,15 @@ static struct ichx_desc avoton_desc = {
> .use_outlvl_cache = true,
> };
>
> +/* Baytrail */
> +static struct ichx_desc baytrail_desc = {
> + .ngpio = 96,
> + .regs = ichx_regs,
> + .reglen = ichx_reglen,
> + .have_blink = true,
> + .use_outlvl_cache = true,
> +};
> +
> static int ichx_gpio_request_regions(struct resource *res_base,
> const char *name, u8 use_gpio)
> {
> @@ -461,6 +470,9 @@ static int ichx_gpio_probe(struct platform_device *pdev)
> case AVOTON_GPIO:
> ichx_priv.desc = &avoton_desc;
> break;
> + case ICH_BAYTRAIL_GPIO:
> + ichx_priv.desc = &baytrail_desc;
> + break;
> default:
> return -ENODEV;
> }
> diff --git a/include/linux/mfd/lpc_ich.h b/include/linux/mfd/lpc_ich.h
> index 2b300b44f994..659a1cd875d8 100644
> --- a/include/linux/mfd/lpc_ich.h
> +++ b/include/linux/mfd/lpc_ich.h
> @@ -34,6 +34,7 @@ enum {
> ICH_V10CORP_GPIO,
> ICH_V10CONS_GPIO,
> AVOTON_GPIO,
> + ICH_BAYTRAIL_GPIO,
> };
>
> struct lpc_ich_info {

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog