Re: [RFC 00/26] perf tools: Introduce hists specific format entries
From: Jiri Olsa
Date: Mon Jan 25 2016 - 09:38:33 EST
On Mon, Jan 25, 2016 at 11:24:24PM +0900, Namhyung Kim wrote:
> Hi Jiri,
>
> On Mon, Jan 25, 2016 at 08:15:52AM +0100, Jiri Olsa wrote:
> > On Mon, Jan 18, 2016 at 10:23:58AM +0100, Jiri Olsa wrote:
> > > hi,
> > > currently we have global format sort and output
> > > lists. This rfc patchset introduces hists object
> > > based format entries to allow the hist object to
> > > carry specific format entries.
> > >
> > > This will allow to have distinguished hist objects
> > > displaying different stuff in output.
>
> The concepth is OK. But I don't want to embed hists into the
> hist_entry for hierarchy mode. As you said it'd be better to factor
> out common bits and embed it both from hists and hist entry. In the
> minimal, two rbroot (for in and out) and a format list would be
> required IMHO.
right.. however this patchset just adds the support to have
format lists (sort and output) defined for the hists object
I plan the 'cutting out common hists' part to come after this
one and after we merge your hierachy view patchset
thanks,
jirka