Re: [PATCH 3/3] serial: pl011: add acpi_match for amba-pl011.c

[Aleksey Makarov]

On 25.01.2016 20:22, Andy Shevchenko wrote:
> On Mon, Jan 25, 2016 at 4:21 PM, Andy Shevchenko
> <andy.shevchenko@xxxxxxxxx> wrote:
> > On Mon, Jan 25, 2016 at 1:45 PM, Aleksey Makarov
> > <aleksey.makarov@xxxxxxxxxx> wrote:
> > > Add an implementation of acpi_match() to the pl011 driver.
> > > It allows to check if the console matches one specified with
> > > ACPI SPCR table.
> >
> > I don't know Rafael's opinion on this, but I would split it to extend
> > ACPI header first with reference to newest revision of Microsoft
> > document.

This makes sense.

> > > --- a/include/acpi/actbl2.h
> > > +++ b/include/acpi/actbl2.h
> > > @@ -371,6 +371,10 @@ struct acpi_dbg2_device {
> > >
> > >   #define ACPI_DBG2_16550_COMPATIBLE  0x0000
> > >   #define ACPI_DBG2_16550_SUBSET      0x0001
> > > +#define ACPI_DBG2_ARM_PL011         0x0003
> > > +#define ACPI_DBG2_ARM_SBSA_GENERIC  0x000e
> > > +#define ACPI_DBG2_ARM_DCC           0x000f
> > > +#define ACPI_DBG2_DCM2835           0x0010
>
> ^^^ Exactly because of such typos. Should be BCM

I will fix this, thank you.