Re: [PATCH 6/6] x86/vdso: Use static_cpu_has()

From: Andy Lutomirski
Date: Mon Jan 25 2016 - 13:46:42 EST


On Sun, Jan 24, 2016 at 1:28 AM, Borislav Petkov <bp@xxxxxxxxx> wrote:
> From: Borislav Petkov <bp@xxxxxxx>
>
> ... and simplify and speed up a tad.

This function is only used when initializing CPUs, so the "tad" is
very small indeed.

If there are systems for which some cpus support rdtscp and some
don't, then this patch is wrong. Of course, if the bsp has rdtscp and
the aps don't, then we're screwed anyway. I left it as cpu_has
because this is a cpu init function and it seemed reasonable.

That being said, I have no meaningful objection to this patch.

--Andy