Re: [PATCHv2 3/4] ARM: tegra: use build-in device properties withrfkill_gpio

From: Marc Dietrich
Date: Mon Jan 25 2016 - 16:02:00 EST


Am Montag 25 Januar 2016, 13:18:40 schrieb Thierry Reding:
> On Mon, Jan 25, 2016 at 12:03:48PM +0300, Heikki Krogerus wrote:
> > Pass the rfkill name and type to the device with properties
> > instead of driver specific platform data.
> >
> > Signed-off-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>
> > CC: Alexandre Courbot <gnurou@xxxxxxxxx>
> > CC: Thierry Reding <thierry.reding@xxxxxxxxx>
> > CC: Stephen Warren <swarren@xxxxxxxxxxxxx>
> > ---
> >
> > arch/arm/mach-tegra/board-paz00.c | 17 ++++++++++-------
> > 1 file changed, 10 insertions(+), 7 deletions(-)
>
> Looks fine to me. We might want to wait for Marc (Cc'ed) to give this a
> spin, since I don't have the hardware. For reference, the series can be
> found here:
>
> http://patchwork.ozlabs.org/patch/572640/
> http://patchwork.ozlabs.org/patch/572644/
> http://patchwork.ozlabs.org/patch/572643/
> http://patchwork.ozlabs.org/patch/572642/
>
> Johannes, I assume that you'll want to take this through your tree
> because of the dependency? In that case:
>
> Acked-by: Thierry Reding <treding@xxxxxxxxxx>

seems to work fine. I wish we could instantiate this from device-tree so we
can finially get rid of this file.

Tested-by: Marc Dietrich <marvin24@xxxxxx>

Attachment: signature.asc
Description: This is a digitally signed message part.