Re: [PATCH] brcmfmac: sdio: Increase the default timeouts a bit
From: Julian Calaby
Date: Mon Jan 25 2016 - 18:42:03 EST
On Tue, Jan 26, 2016 at 2:39 AM, Arend van Spriel <aspriel@xxxxxxxxx> wrote:
> On 25-01-16 12:06, Julian Calaby wrote:
>> Hi Sjoerd,
>> On Mon, Jan 25, 2016 at 9:47 PM, Sjoerd Simons
>> <sjoerd.simons@xxxxxxxxxxxxxxx> wrote:
>>> On a Radxa Rock2 board with a Ampak AP6335 (Broadcom 4339 core) it seems
>>> the card responds very quickly most of the time, unfortunately during
>>> initialisation it sometimes seems to take just a bit over 2 seconds to
>>> This results intialization failing with message like:
>>> brcmf_c_preinit_dcmds: Retreiving cur_etheraddr failed, -52
>>> brcmf_bus_start: failed: -52
>>> brcmf_sdio_firmware_callback: dongle is not responding
>>> Increasing the timeout to allow for a bit more headroom allows the
>>> card to initialize reliably.
>>> A quick search online after diagnosing/fixing this showed that Google
>>> has a similar patch in their ChromeOS tree, so this doesn't seem
>>> specific to the board I'm using.
>>> Signed-off-by: Sjoerd Simons <sjoerd.simons@xxxxxxxxxxxxxxx>
>> Looks sane to me.
>> Reviewed-by: Julian Calaby <julian.calaby@xxxxxxxxx>
> Not really a cleanup patch :-p , but thanks for the review.
I'm trying to review any "small" patch from (relatively) new people.