Re: [PATCH v2] pci: fix unavailable irq number 255 reported by BIOS

From: Guenter Roeck
Date: Mon Jan 25 2016 - 23:05:38 EST


On Mon, Jan 25, 2016 at 02:58:04PM -0600, Bjorn Helgaas wrote:
> [+cc Thomas]
>
[ ... ]

>
> I don't like the x86 ifdef. I'd prefer:
>
> static inline bool irq_valid(unsigned int irq)
> {
> if (irq < NR_IRQS)
> return true;
> return false;
> }
>

Or:

static inline bool irq_valid(unsigned int irq)
{
return irq < NR_IRQS;
}

Guenter