Re: [RFC PATCH] PPC32: Fix build failure caused by missing dirty pte handlers

[Pranith Kumar]

On Mon, Jan 25, 2016 at 10:13 PM, Michael Ellerman <mpe@xxxxxxxxxxxxxx> wrote:
> On Mon, 2016-01-25 at 09:22 -0500, Pranith Kumar wrote:
>
>> In 4.5-rc1, I am getting a build failure as follows:
>>
>> mm/memory.c: In function âdo_swap_pageâ:
>> mm/memory.c:2573:9: error: implicit declaration of function âpte_mksoft_dirtyâ
>> [-Werror=implicit-function-declaration]
>>    pte = pte_mksoft_dirty(pte);
>>
>> The soft dirty pte handlers are declared only for PPC64 on PPC_BOOK3S in
>> arch/powerpc/include/asm/book3s/64/hash.h and missing in the 32-bit arch.
>>
>> Avoid this error by not setting HAVE_ARCH_SOFT_DIRTY for 32-bit system.
>
> It's building for me, what config are you using?
>
> http://kisskb.ellerman.id.au/kisskb/buildresult/12597204/
>

I am not sure where I messed up, but I am getting the following error now.
Config attached. The same patch fixes this error.

In file included from fs/proc/task_mmu.c:14:0:
include/linux/swapops.h: In function âpte_to_swp_entryâ:
include/linux/swapops.h:69:6: error: implicit declaration of function
âpte_swp_soft_dirtyâ [-Werror=implicit-function-declaration]
  if (pte_swp_soft_dirty(pte))
      ^
include/linux/swapops.h:70:9: error: implicit declaration of function
âpte_swp_clear_soft_dirtyâ [-Werror=implicit-function-declaration]
   pte = pte_swp_clear_soft_dirty(pte);
         ^
fs/proc/task_mmu.c: In function âclear_soft_dirtyâ:
fs/proc/task_mmu.c:876:11: error: implicit declaration of function
âpte_clear_soft_dirtyâ [-Werror=implicit-function-declaration]
   ptent = pte_clear_soft_dirty(ptent);
           ^
fs/proc/task_mmu.c: In function âpte_to_pagemap_entryâ:
fs/proc/task_mmu.c:1158:7: error: implicit declaration of function
âpte_soft_dirtyâ [-Werror=implicit-function-declaration]
   if (pte_soft_dirty(pte))
       ^
cc1: some warnings being treated as errors



-- 
Pranith

Attachment: config-failure
Description: Binary data