Re: [PATCH v2] ata: add AMD Seattle platform driver

From: Hans de Goede
Date: Tue Jan 26 2016 - 04:37:11 EST


Hi,

On 25-01-16 21:43, Tejun Heo wrote:
On Thu, Jan 14, 2016 at 10:31:11AM -0600, Brijesh Singh wrote:
AMD Seattle SATA controller mostly conforms to AHCI interface with some
special register to control SGPIO interface. In the case of an AHCI
controller, the SGPIO feature is ideally implemented using the
"Enclosure Management" register of the AHCI controller, but those
registeres are not implemented in the Seattle SoC. Instead SoC
(Rev B0 onwards) provides a 32-bit SGPIO control register which should
be programmed to control the activity, locate and fault LEDs.

The driver is based on ahci_platform driver.

Signed-off-by: Brijesh Singh <brijesh.singh@xxxxxxx>
Acked-by: Hans de Goede <hdegoede@xxxxxxxxxx>
CC: tj@xxxxxxxxxx
CC: linux-ide@xxxxxxxxxxxxxxx

Hans, can you please review the patch?

Done, driver looks good to me:

Acked-by: Hans de Goede <hdegoede@xxxxxxxxxx>

Regards,

Hans