Re: [PATCH 21/22] mtd: cs553x: Fix dependencies for !HAS_IOMEM archs

[Geert Uytterhoeven]

Hi Richard,

On Mon, Jan 25, 2016 at 11:24 PM, Richard Weinberger <richard@xxxxxx> wrote:
> Not every arch has io memory nor can this driver ever work
> on UML/i386.
> So, unbreak the build by fixing the dependencies.
>
> Signed-off-by: Richard Weinberger <richard@xxxxxx>
> ---
>  drivers/mtd/nand/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
> index 545d82b..b253654 100644
> --- a/drivers/mtd/nand/Kconfig
> +++ b/drivers/mtd/nand/Kconfig
> @@ -311,6 +311,7 @@ config MTD_NAND_CAFE
>  config MTD_NAND_CS553X
>         tristate "NAND support for CS5535/CS5536 (AMD Geode companion chip)"
>         depends on X86_32
> +       depends on !UML && HAS_IOMEM

I don't think there's a need for the !UML dependency?
Hence just "depends on X86_32 && HAS_IOMEM"?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds