Re: [PATCH] Revert "regmap-mmio: Use native endianness for read/write"

From: Mark Brown
Date: Tue Jan 26 2016 - 06:37:06 EST

On Tue, Jan 26, 2016 at 10:24:22AM +0100, Johannes Berg wrote:
> On Tue, 2016-01-26 at 10:09 +0100, Arnd Bergmann wrote:

> > However, we have some freedom at the regmap-mmio level, which we can
> > sanitize in 4.6 if we want to make it more consistent with the rest
> > of regmap. We have around 50 callers of {devm_,}regmap_init_mmio()
> > and almost all of them do not specify endianess but expect little-
> > endian behavior. We can change all existing instances to set
> > REGMAP_ENDIAN_NATIVE explicitly and change regmap_init_mmio() to
> > return an error if the caller does not specify a particular endianess
> > (big, little, native).

> I'm not sure that we can, since regmap also takes the value from the DT
> directly, and it seems that a driver passing it would mean the DT value
> is no longer honoured?

DT should override the value in the driver rather than the other way

Attachment: signature.asc
Description: PGP signature