Re: [PATCH] cgroup: Fix misspelling of CONFIG_SOCK_CGROUP_DATA in comments
From: Andreas Ziegler
Date: Tue Jan 26 2016 - 10:14:37 EST
On 01/26/2016 16:08, Rosen, Rami wrote:
> --- a/include/linux/cgroup.h
> +++ b/include/linux/cgroup.h
> @@ -604,11 +604,11 @@ static inline struct cgroup *sock_cgroup_ptr(struct sock_cgroup_data *skcd)
> In this occasion, seems that maybe something else is also missing:
> Shouldn't it be hereafter : +#else /* !CONFIG_SOCK_CGROUP_DATA */
> instead ?
> -#else /* CONFIG_CGROUP_DATA */
> +#else /* CONFIG_SOCK_CGROUP_DATA */
It seems that there is no real consensus among the developers for that
ziegler@box:~/linux$ git grep "#else \/\* \!CONFIG_" | wc -l
ziegler@box:~/linux$ git grep "#else \/\* CONFIG_" | wc -l
I don't mind changing it, I'm just not sure if that's what we want.