Re: [PATCH] qe_ic: fix a buffer overflow error and add check elsewhere

From: Scott Wood
Date: Tue Jan 26 2016 - 13:09:01 EST

On Tue, 2016-01-26 at 18:31 +0100, Thomas Gleixner wrote:
> On Thu, 21 Jan 2016, Zhao Qiang wrote:
> > 127 is the theoretical up boundary of QEIC number,
> > in fact there only be 44 qe_ic_info now.
> > add check to overflow for qe_ic_info
> How do you trigger that overflow? The above does not explain WHY we need
> these
> checks.

The check in qe_ic_host_map can be triggered by bad data in a device tree.

The set_priority functions do not appear to be used at all.

> > diff --git a/drivers/soc/fsl/qe/qe_ic.c b/drivers/soc/fsl/qe/qe_ic.c
> > index 5419527..90c00b7 100644
> > --- a/drivers/soc/fsl/qe/qe_ic.c
> > +++ b/drivers/soc/fsl/qe/qe_ic.c
> Sigh. Another dump ground for SOC stuff?

Another? Where are the others, besides arch?

> irq chip drivers belong into drivers/irqchip.

Yes. This stuff was recently moved out of arch/powerpc to work toward being
able to use it on ARM. I'm expecting followup patches to move things like
this that belong elsewhere.