Re: [v3,11/41] mips: reuse asm-generic/barrier.h

From: Paul E. McKenney
Date: Tue Jan 26 2016 - 17:00:53 EST


On Tue, Jan 26, 2016 at 11:09:27AM +0000, Will Deacon wrote:
> On Tue, Jan 26, 2016 at 11:32:00AM +0100, Peter Zijlstra wrote:
> > On Tue, Jan 26, 2016 at 11:24:02AM +0100, Peter Zijlstra wrote:
> >
> > > Yeah, this goes under the header: memory-barriers.txt is _NOT_ a
> > > specification (I seem to keep repeating this).
> >
> > Do we want this ?

Seems likely to me. ;-)

> > ---
> > Documentation/memory-barriers.txt | 17 +++++++++++++++++
> > 1 file changed, 17 insertions(+)
> >
> > diff --git a/Documentation/memory-barriers.txt b/Documentation/memory-barriers.txt
> > index a61be39c7b51..433326ebdc26 100644
> > --- a/Documentation/memory-barriers.txt
> > +++ b/Documentation/memory-barriers.txt
> > @@ -1,3 +1,4 @@
> > +
> > ============================
> > LINUX KERNEL MEMORY BARRIERS
> > ============================
> > @@ -5,6 +6,22 @@
> > By: David Howells <dhowells@xxxxxxxxxx>
> > Paul E. McKenney <paulmck@xxxxxxxxxxxxxxxxxx>
> >
> > +==========
> > +DISCLAIMER
> > +==========
> > +
> > +This document is not a specification; it is intentionally (for the sake of
> > +brevity) and unintentionally (due to being human) incomplete. This document is
> > +meant as a guide to using the various memory barriers provided by Linux, but
> > +in case of any doubt (and there are many) please ask.
>
> It might be worth adding you and me to the top of the file, to save Paul
> Cc'ing us on questions (get_maintainer.pl points at poor old Corbet for
> this file).
>
> But yes, it seems that something like this is required.

So Peter, would you like to update your patch to include yourself
and Will as authors?

Thanx, Paul