Re: [PATCH v3 07/10] rtc: max77686: Use dev_warn() instead of pr_warn()

From: Javier Martinez Canillas
Date: Tue Jan 26 2016 - 20:54:08 EST

Hello Andi,

Thanks a lot for your feedback and review.

On 01/26/2016 10:22 PM, Andi Shyti wrote:
Hi Javier,

if (tm->tm_year < 100) {
- pr_warn("RTC can't handle year %d. Assume it's 2000.\n",
- 1900 + tm->tm_year);
+ dev_warn(info->dev,
+ "RTC can't handle year %d. Assume it's 2000\n",
+ 1900 + tm->tm_year);
return -EINVAL;

Because we are returning an error value, why not use dev_err()?

You are absolutely right. Since the driver was using pr_warn(), I used
dev_warn() but dev_err() would had been correct.

If you don't mind I plan to do it as a follow up patch to avoid having
to resend the whole series only for this change.
Best regards,
Javier Martinez Canillas
Open Source Group
Samsung Research America