Re: [PATCH 2/3] mm: Convert vm_insert_pfn_prot to vmf_insert_pfn_prot
From: Matthew Wilcox
Date: Tue Jan 26 2016 - 23:18:34 EST
On Mon, Jan 25, 2016 at 09:35:36AM -0800, Andy Lutomirski wrote:
> On Mon, Jan 25, 2016 at 9:25 AM, Matthew Wilcox
> <matthew.r.wilcox@xxxxxxxxx> wrote:
> > From: Matthew Wilcox <willy@xxxxxxxxxxxxxxx>
> >
> > Other than the name, the vmf_ version takes a pfn_t parameter, and
> > returns a VM_FAULT_ code suitable for returning from a fault handler.
> >
> > This patch also prevents vm_insert_pfn() from returning -EBUSY.
> > This is a good thing as several callers handled it incorrectly (and
> > none intentionally treat -EBUSY as a different case from 0).
> >
> > Signed-off-by: Matthew Wilcox <willy@xxxxxxxxxxxxxxx>
>
> This would be even nicer if you added vmf_insert_pfn as well :)
I've sent out patches adding it before ... my most recent attempt on
January 5th tied up with the DAX support for 1GB pages. I'll keep
sending it until it sticks :-)