RE: undefined reference to `snd_timer_interrupt'

[Jie, Yang]

>-----Original Message-----
>From: Takashi Iwai [mailto:tiwai@xxxxxxx]
>Sent: Wednesday, January 27, 2016 2:14 PM
>To: Wu, Fengguang
>Cc: Jie, Yang; kbuild-all@xxxxxx; linux-kernel@xxxxxxxxxxxxxxx
>Subject: Re: undefined reference to `snd_timer_interrupt'
>
>On Tue, 26 Jan 2016 23:16:55 +0100,
>kbuild test robot wrote:
>>
>> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
>master
>> head:   92e963f50fc74041b5e9e744c330dca48e04f08d
>> commit: 90bbaf66ee7b946952f1e82a0069639dea5fd893 ALSA: timer: add
>config item to export PCM timer disabling for expert
>> date:   3 months ago
>> config: x86_64-randconfig-s0-01270516 (attached as .config)
>> reproduce:
>>         git checkout 90bbaf66ee7b946952f1e82a0069639dea5fd893
>>         # save the attached .config to linux build tree
>>         make ARCH=x86_64
>>
>> All errors (new ones prefixed by >>):
>>
>>    sound/built-in.o: In function `snd_emu10k1_interrupt':
>> >> (.text+0x604c7): undefined reference to `snd_timer_interrupt'
>>    sound/built-in.o: In function `snd_emu10k1_timer':
>> >> (.text+0x70d5d): undefined reference to `snd_timer_new'
>
>Fixed by the patch below.
 
Thanks, I also just worked out the exactly same patch and planning
to submit.  So now I can enjoy a cup of tea :-

thanks,
~Keyon
>
>
>thanks,
>
>Takashi
>
>-- 8< --
>From: Takashi Iwai <tiwai@xxxxxxx>
>Subject: [PATCH] ALSA: Add missing dependency on CONFIG_SND_TIMER
>
>Since the build of PCM timer may be disabled via Kconfig now, each
>driver that provides a timer interface needs to set CONFIG_SND_TIMER
>explicitly.  Otherwise it may get a build error due to missing
>symbol.
>
>Fixes: 90bbaf66ee7b ('ALSA: timer: add config item to export PCM timer
>disabling for expert')
>Reported-by: kbuild test robot <fengguang.wu@xxxxxxxxx>
>Cc: <stable@xxxxxxxxxxxxxxx> # v4.4+
>Signed-off-by: Takashi Iwai <tiwai@xxxxxxx>
>---
> sound/isa/Kconfig   | 4 ++++
> sound/pci/Kconfig   | 3 +++
> sound/sparc/Kconfig | 1 +
> 3 files changed, 8 insertions(+)
>
>diff --git a/sound/isa/Kconfig b/sound/isa/Kconfig
>index 0216475fc759..37adcc6cbe6b 100644
>--- a/sound/isa/Kconfig
>+++ b/sound/isa/Kconfig
>@@ -3,6 +3,7 @@
> config SND_WSS_LIB
>         tristate
>         select SND_PCM
>+	select SND_TIMER
>
> config SND_SB_COMMON
>         tristate
>@@ -42,6 +43,7 @@ config SND_AD1816A
> 	select SND_OPL3_LIB
> 	select SND_MPU401_UART
> 	select SND_PCM
>+	select SND_TIMER
> 	help
> 	  Say Y here to include support for Analog Devices SoundPort
> 	  AD1816A or compatible sound chips.
>@@ -209,6 +211,7 @@ config SND_GUSCLASSIC
> 	tristate "Gravis UltraSound Classic"
> 	select SND_RAWMIDI
> 	select SND_PCM
>+	select SND_TIMER
> 	help
> 	  Say Y here to include support for Gravis UltraSound Classic
> 	  soundcards.
>@@ -221,6 +224,7 @@ config SND_GUSEXTREME
> 	select SND_OPL3_LIB
> 	select SND_MPU401_UART
> 	select SND_PCM
>+	select SND_TIMER
> 	help
> 	  Say Y here to include support for Gravis UltraSound Extreme
> 	  soundcards.
>diff --git a/sound/pci/Kconfig b/sound/pci/Kconfig
>index 656ce39bddbc..8f6594a7d37f 100644
>--- a/sound/pci/Kconfig
>+++ b/sound/pci/Kconfig
>@@ -155,6 +155,7 @@ config SND_AZT3328
> 	select SND_PCM
> 	select SND_RAWMIDI
> 	select SND_AC97_CODEC
>+	select SND_TIMER
> 	depends on ZONE_DMA
> 	help
> 	  Say Y here to include support for Aztech AZF3328 (PCI168)
>@@ -463,6 +464,7 @@ config SND_EMU10K1
> 	select SND_HWDEP
> 	select SND_RAWMIDI
> 	select SND_AC97_CODEC
>+	select SND_TIMER
> 	depends on ZONE_DMA
> 	help
> 	  Say Y to include support for Sound Blaster PCI 512, Live!,
>@@ -889,6 +891,7 @@ config SND_YMFPCI
> 	select SND_OPL3_LIB
> 	select SND_MPU401_UART
> 	select SND_AC97_CODEC
>+	select SND_TIMER
> 	help
> 	  Say Y here to include support for Yamaha PCI audio chips -
> 	  YMF724, YMF724F, YMF740, YMF740C, YMF744, YMF754.
>diff --git a/sound/sparc/Kconfig b/sound/sparc/Kconfig
>index d75deba5617d..dfcd38647606 100644
>--- a/sound/sparc/Kconfig
>+++ b/sound/sparc/Kconfig
>@@ -22,6 +22,7 @@ config SND_SUN_AMD7930
> config SND_SUN_CS4231
> 	tristate "Sun CS4231"
> 	select SND_PCM
>+	select SND_TIMER
> 	help
> 	  Say Y here to include support for CS4231 sound device on Sun.
>
>--
>2.7.0