Re: [PATCH 01/22] power: reset: Fix dependencies for !HAS_IOMEM archs
From: Richard Weinberger
Date: Wed Jan 27 2016 - 03:03:05 EST
Am 27.01.2016 um 00:34 schrieb Florian Fainelli:
> On 25/01/16 14:24, Richard Weinberger wrote:
>> Not every arch has io memory.
>> So, unbreak the build by fixing the dependencies.
>> Signed-off-by: Richard Weinberger <richard@xxxxxx>
>> drivers/power/reset/Kconfig | 2 ++
>> 1 file changed, 2 insertions(+)
>> diff --git a/drivers/power/reset/Kconfig b/drivers/power/reset/Kconfig
>> index 1131cf7..0a6408a 100644
>> --- a/drivers/power/reset/Kconfig
>> +++ b/drivers/power/reset/Kconfig
>> @@ -148,6 +148,7 @@ config POWER_RESET_KEYSTONE
>> config POWER_RESET_SYSCON
>> bool "Generic SYSCON regmap reset driver"
>> depends on OF
>> + depends on HAS_IOMEM
>> select MFD_SYSCON
> Should this dependency go into REGMAP_MMIO instead? MFD_SYSCON in itself
> does not issue I/O accesses per-se, but does use helpers from regmap,
> which in turn do it.
Hmmm, AFAICT this would not work as REGMAP_MMIO is not user visible and directly enabled
via "select" instead of "depends on". Hence, dependencies are ignored.